SPLAT-2562: Added 3CMO OTE binary to extensionBinary list by vr4manta · Pull Request #31004 · openshift/origin

vr4manta · 2026-04-13T18:09:30Z

Changes

Added 3CMO OTE binary to extensionBinary list

Summary by CodeRabbit

Tests
- Added support for an additional test binary for the cluster-cloud-controller-manager-operator, expanding available extension test artifacts and improving automated test coverage and validation for that component. No existing test entries were removed, enabling broader scenario validation in CI without altering current test configurations.

openshift-merge-bot · 2026-04-13T18:09:33Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-04-13T18:09:35Z

@vr4manta: This pull request references SPLAT-2562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2562

Changes

Added 3CMO OTE binary to extensionBinary list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-13T18:09:39Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-04-13T18:09:42Z

@vr4manta: This pull request references SPLAT-2562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2562

Changes

Added 3CMO OTE binary to extensionBinary list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-04-13T18:09:54Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bd3ae780-6d6b-49b6-9132-e06cf314f0f3

📥 Commits

Reviewing files that changed from the base of the PR and between 49ac512 and d6c2c12.

📒 Files selected for processing (1)

pkg/test/extensions/binary.go

🚧 Files skipped from review as they are similar to previous changes (1)

pkg/test/extensions/binary.go

Walkthrough

Added a new TestBinary entry to the extensionBinaries registry in pkg/test/extensions/binary.go, mapping the cluster-cloud-controller-manager-operator image tag to an external binary path.

Changes

Cohort / File(s)	Summary
Test Extension Binary Registry `pkg/test/extensions/binary.go`	Appended a `TestBinary` entry to the `extensionBinaries` slice for `imageTag: "cluster-cloud-controller-manager-operator"` with `binaryPath: "/usr/bin/cloud-controller-manager-operator-tests-ext.gz"`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Ote Binary Stdout Contract	❓ Inconclusive	PR adds registry entry for external OTE binary from cluster-cloud-controller-manager-operator, but binary source code is not present in this repository to verify stdout contract compliance.	Verify compliance by examining cluster-cloud-controller-manager-operator repository's OTE binary source code to ensure no non-JSON stdout output from main(), init(), or top-level code.

✅ Passed checks (9 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main change: adding a 3CMO OTE binary to the extensionBinary list, which directly matches the changeset that adds a new entry to the extensionBinaries registry.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	Pull request modifies only extensionBinaries registry with static configuration values; no dynamic test identifiers or Ginkgo test definitions are present.
Test Structure And Quality	✅ Passed	This pull request is not applicable to the custom check for Ginkgo test code quality as it only adds a configuration entry to the extensionBinaries registry, not Ginkgo test specifications.
Microshift Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests to the codebase. It only adds a configuration entry to the extensionBinaries registry that registers an additional external test binary from the cluster-cloud-controller-manager-operator image.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only adds a reference to an external test binary in the extensionBinaries registry, not new Ginkgo test definitions.
Topology-Aware Scheduling Compatibility	✅ Passed	The pull request does not introduce any topology-aware scheduling concerns as it only adds a test binary reference to the extension test framework configuration.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR modifies pkg/test/extensions/binary.go, a configuration registry file with no Ginkgo test constructs. No new e2e tests are added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-04-13T18:10:36Z

@vr4manta: This pull request references SPLAT-2562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

SPLAT-2562

Changes

Added 3CMO OTE binary to extensionBinary list

Summary by CodeRabbit

Tests

Added test binary support for cluster-cloud-controller-manager-operator to enhance test coverage and validation capabilities.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-04-13T18:16:58Z

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f266b2b0-3764-11f1-8c07-104d53b44395-0

openshift-ci · 2026-04-13T18:17:12Z

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-upi-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb832810-3764-11f1-8907-5666d5c705c5-0

openshift-ci · 2026-04-14T12:16:46Z

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c1446500-37fb-11f1-9e15-01b3d3bcf6b0-0

openshift-ci · 2026-04-14T12:17:04Z

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-upi-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d02b1780-37fb-11f1-8e58-f4f4ae1466a8-0

openshift-ci · 2026-04-15T15:21:18Z

@vr4manta: This PR was included in a payload test run from openshift/cluster-cloud-controller-manager-operator#446
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bcd8dc60-38de-11f1-8429-118b8b845f66-0

vr4manta · 2026-04-17T16:14:46Z

/hold
holding till other PR merges

openshift-merge-bot · 2026-04-17T16:44:20Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-04-20T11:06:30Z

@vr4manta: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#335
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fa41bae0-3ca8-11f1-802a-6f8be7fb98ab-0

openshift-ci · 2026-04-20T11:18:26Z

@vr4manta: This PR was included in a payload test run from openshift/vmware-vsphere-csi-driver-operator#335
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-hybrid-env-serial-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9bffde60-3caa-11f1-9f2d-f42df4e0ec78-0

vr4manta · 2026-04-24T11:11:07Z

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-hybrid-env-techpreview

openshift-ci · 2026-04-24T11:11:11Z

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-hybrid-env-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b303760-3fce-11f1-8858-a8f8acca037f-0

vr4manta · 2026-04-24T11:12:27Z

/retest

vr4manta · 2026-04-27T19:51:30Z

/assign @deads2k

neisw · 2026-04-28T14:49:59Z

/pipeline required

openshift-merge-bot · 2026-04-28T14:50:03Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-trt · 2026-04-28T19:48:29Z

Job Failure Risk Analysis for sha: d6c2c12

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2	IncompleteTests Tests for this run (20) are below the historical average (1849): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

vr4manta · 2026-04-29T11:13:38Z

/unhold

petr-muller · 2026-04-29T11:27:12Z

/approve

neisw · 2026-04-29T15:27:12Z

/test e2e-aws-ovn-serial-2of2

jcpowermac · 2026-04-30T11:13:40Z

/lgtm

vr4manta · 2026-04-30T11:14:35Z

/verified by @vr4manta

openshift-ci-robot · 2026-04-30T11:14:47Z

@vr4manta: This PR has been marked as verified by @vr4manta.

Details

In response to this:

/verified by @vr4manta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-04-30T11:28:06Z

/retest-required

Remaining retests: 0 against base HEAD 231811f and 2 for PR HEAD d6c2c12 in total

mtulio

/lgtm

openshift-ci · 2026-04-30T11:38:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, mtulio, petr-muller, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-04-30T14:17:53Z

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2026

vr4manta mentioned this pull request Apr 13, 2026

SPLAT-2562: Refactored OTE and added new 3CMO OTE binary openshift/cluster-cloud-controller-manager-operator#446

Merged

vr4manta marked this pull request as ready for review April 17, 2026 16:14

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2026

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2026

openshift-ci Bot requested review from deads2k and sjenning April 17, 2026 16:15

vr4manta mentioned this pull request Apr 20, 2026

SPLAT-2562: Created OTE extension with tests for hybrid env openshift/vmware-vsphere-csi-driver-operator#335

Merged

Added 3CMO OTE binary to extensionBinary list

d6c2c12

vr4manta force-pushed the SPLAT-2562 branch from 49ac512 to d6c2c12 Compare April 20, 2026 20:49

openshift-ci Bot assigned deads2k Apr 27, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026

openshift-ci Bot assigned jcpowermac Apr 30, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 30, 2026

mtulio reviewed Apr 30, 2026

View reviewed changes

openshift-ci Bot assigned mtulio Apr 30, 2026

openshift-merge-bot Bot merged commit 4078649 into openshift:main Apr 30, 2026
21 checks passed

Conversation

vr4manta commented Apr 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

openshift-ci Bot commented Apr 13, 2026

Uh oh!

openshift-ci-robot commented Apr 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

coderabbitai Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks failed

❌ Failed checks (1 inconclusive)

Uh oh!

openshift-ci-robot commented Apr 13, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Apr 13, 2026

Uh oh!

openshift-ci Bot commented Apr 13, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 14, 2026

Uh oh!

openshift-ci Bot commented Apr 15, 2026

Uh oh!

vr4manta commented Apr 17, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 17, 2026

Uh oh!

openshift-ci Bot commented Apr 20, 2026

Uh oh!

openshift-ci Bot commented Apr 20, 2026

Uh oh!

vr4manta commented Apr 24, 2026

Uh oh!

openshift-ci Bot commented Apr 24, 2026

Uh oh!

vr4manta commented Apr 24, 2026

Uh oh!

vr4manta commented Apr 27, 2026

Uh oh!

neisw commented Apr 28, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 28, 2026

Uh oh!

openshift-trt Bot commented Apr 28, 2026

Uh oh!

vr4manta commented Apr 29, 2026

Uh oh!

petr-muller commented Apr 29, 2026

Uh oh!

neisw commented Apr 29, 2026

Uh oh!

jcpowermac commented Apr 30, 2026

Uh oh!

vr4manta commented Apr 30, 2026

Uh oh!

openshift-ci-robot commented Apr 30, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 30, 2026

Uh oh!

mtulio left a comment

Choose a reason for hiding this comment

Uh oh!

vr4manta commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Apr 13, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 13, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

openshift-ci-robot commented Apr 13, 2026 •

edited by openshift-ci Bot

Loading